Skip to content

Switch to nanoserver images for windows. They're smaller and faster! #2124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Switch to nanoserver images for windows. They're smaller and faster! #2124

wants to merge 1 commit into from
+2 −2

Conversation

julianKatz
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Windows builds are very slow! This is partially due to the size of the servercore base images we use.

Change to nanoserver images removes much of the bloat (UIs, lots of parts of windows).

I tested the build-and-push... commands for both windows versions with servercore and nanoserver:

Servercore: lstc2019 took 8 min, 21 seconds
Nanoserver: ltsc2019 took 3 min, 38 seconds

Servercore: ltsc2022 took 8 min, 29 seconds
Nanoserver: ltsc2022 took 1 min, 45 seconds

Big improvements! Let's see if it passes the tests.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

None

@julianKatz
Switch to nanoserver images for windows. They're smaller and faster!
1315dcb 
Servercore: lstc2019 took 8 min, 21 seconds
Nanoserver: ltsc2019 took 3 min, 38 seconds

Servercore: ltsc2022 took 8 min, 29 seconds
Nanoserver: ltsc2022 took 1 min, 45 seconds
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 2, 2025
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 2, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: julianKatz
Once this PR has been reviewed and has the lgtm label, please assign amacaskill for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from mattcary and tyuchn July 2, 2025 01:17
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 2, 2025
@julianKatz
Copy link
Contributor Author

/test all

@julianKatz
Copy link
Contributor Author

/test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019

@k8s-ci-robot
Copy link
Contributor

@julianKatz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019 1315dcb link false /test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019
pull-gcp-compute-persistent-disk-csi-driver-e2e-arm 1315dcb link true /test pull-gcp-compute-persistent-disk-csi-driver-e2e-arm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcary mattcary Awaiting requested review from mattcary

@tyuchn tyuchn Awaiting requested review from tyuchn

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julianKatz @k8s-ci-robot